Skip to content

Latest commit

 

History

History
55 lines (36 loc) · 1.43 KB

no-test-support-import.md

File metadata and controls

55 lines (36 loc) · 1.43 KB
Raw

no-test-support-import

✅ The "extends": "plugin:ember/recommended" property in a configuration file enables this rule.

No importing of test support files into non-test code..

TL;DR Do not import from a file located in addon-test-support into non-test code. Doing so will result in production errors that are not capable of being caught in tests as require statements are available in tests but not on production builds.

Examples

Examples of incorrect code for this rule:

app/routes/index.js

import doSomething from '../test-support/some-other-test';

import Route from '@ember/routing/route';
import { action } from '@ember/object';

export default class SomeRouteRoute extends Route {
  // …
  model() {
    return doSomething();
  }
}

Examples of correct code for this rule:

tests/unit/foo-test.js

import setupModule from '../test-support/setup-module';
import { module, test } from 'qunit';

module('Acceptance | module', setupModule());

addon-test-support/setupApplication.js

import setupModule from '../test-support/setup-module';

export default function setupApplicationTest(hooks) {
  setupModule(hooks);
  // ...
}

This is meant as an addition to the no-test-import-export rule as these files do represent test files but are located in addon-test-support rather than in /tests/.

Related Rules