From bc869497ca067ac5960992c5add8df57ec945b3a Mon Sep 17 00:00:00 2001 From: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com> Date: Mon, 6 Nov 2023 19:43:26 -0500 Subject: [PATCH] fix(external-dns): Fix hidden provider credentials (#14404) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** ⚒️ Fixes # **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/incubator/external-dns/Chart.yaml | 2 +- charts/incubator/external-dns/questions.yaml | 10 +--------- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/charts/incubator/external-dns/Chart.yaml b/charts/incubator/external-dns/Chart.yaml index fa080a027877..73cfaa2ae871 100644 --- a/charts/incubator/external-dns/Chart.yaml +++ b/charts/incubator/external-dns/Chart.yaml @@ -22,7 +22,7 @@ sources: - https://github.com/truecharts/charts/tree/master/charts/incubator/external-dns - https://github.com/kubernetes-sigs/external-dns type: application -version: 0.0.3 +version: 0.0.4 annotations: truecharts.org/category: networking truecharts.org/SCALE-support: "true" diff --git a/charts/incubator/external-dns/questions.yaml b/charts/incubator/external-dns/questions.yaml index 03782da2cd1f..740c96d8dfdd 100644 --- a/charts/incubator/external-dns/questions.yaml +++ b/charts/incubator/external-dns/questions.yaml @@ -10,7 +10,7 @@ questions: # Include{podSpec} # Include{containerMain} - variable: env - label: "Provider Credentials" + label: "Provider Specific Credentials - Main Config Below" schema: additional_attrs: true type: dict @@ -20,14 +20,12 @@ questions: description: Cloudflare API Key if not using the preferred API Token schema: type: string - show_if: [["provider", "=", "cloudflare"]] default: "" - variable: CF_API_EMAIL label: Cloudflare API Email description: Cloudflare API email if not using the preferred API Token schema: type: string - show_if: [["provider", "=", "cloudflare"]] default: "" - variable: DO_TOKEN label: Digitalocean API Key @@ -40,21 +38,18 @@ questions: description: schema: type: string - show_if: [["provider", "=", "dnsimple"]] default: "" - variable: LINODE_TOKEN label: Linode PI Key description: Needed for read / write access on Linode schema: type: string - show_if: [["provider", "=", "linode"]] default: "" - variable: OVH_APPLICATION_KEY label: OVH Application Key description: OVH Application Key schema: type: string - show_if: [["provider", "=", "ovh"]] default: "" - variable: OVH_APPLICATION_SECRET label: OVH Application Secret @@ -67,21 +62,18 @@ questions: description: Your OVH Consumer key after validated link schema: type: string - show_if: [["provider", "=", "ovh"]] default: "" - variable: SCW_ACCESS_KEY label: Scaleway Access Key description: Your Scaleway Access Key schema: type: string - show_if: [["provider", "=", "scaleway"]] default: "" - variable: SCW_SECRET_KEY label: Scaleway Secret Key description: Your Scaleway Secret Key schema: type: string - show_if: [["provider", "=", "scaleway"]] default: "" # Include{containerBasic} # Include{containerAdvanced}