Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callbacks in GLWin not working in objects that aren't subclasses of GLWin #28

Open
dkrautha opened this issue Jul 13, 2021 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@dkrautha
Copy link
Collaborator

Mainly to allow making keybinds in AudioPlayer and VideoPlayer

@ahuston-0 ahuston-0 self-assigned this Jul 13, 2021
@ahuston-0 ahuston-0 added bug Something isn't working enhancement New feature or request labels Jul 13, 2021
@ahuston-0
Copy link
Collaborator

@dkrautha implemented a promising alternative to this called WantsInput. It currently just intercepts key callbacks, but could be implemented to work with other types of callbacks as well. Both this and WantsInput will need to be finished and compared to determine which is the better solution, but WantsInput may end up being the more efficient of the two (as it doesn't seem to require any function pointers or std::functions, and instead takes a pointer to the class).

ahuston-0 added a commit that referenced this issue Jul 16, 2021
@ahuston-0 ahuston-0 linked a pull request Aug 19, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants