Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jacobian to GeneralizedLorentz1D, SmoothBrokenPowerLaw in stingray.simulator.models #889

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ankitkhushwaha
Copy link
Contributor

@ankitkhushwaha ankitkhushwaha commented Feb 24, 2025

TODO:

i have added the jacabian for each parameter in both GeneralizedLorentz1D, SmoothBrokenPowerLaw function.

i have confirmed that jacobian for function with respect to each parameter is correct.

@matteobachetti

@ankitkhushwaha ankitkhushwaha marked this pull request as draft February 24, 2025 12:24
@ankitkhushwaha ankitkhushwaha marked this pull request as ready for review February 25, 2025 12:27
@ankitkhushwaha
Copy link
Contributor Author

ankitkhushwaha commented Feb 25, 2025

I think changes are ready for review.
@matteobachetti

@matteobachetti
Copy link
Member

@ankitkhushwaha thanks for your PR. However, I haven't noticed any tests failing, there are no issues open about it as far as I can tell. Could you be clearer about what is failing, and what your changes do?

@ankitkhushwaha
Copy link
Contributor Author

ankitkhushwaha commented Feb 25, 2025

@matteobachetti
in the first commit. Function GeneralizedLorentz1D, SmoothBrokenPowerLaw was returning the jacobian and function output as tuple. that's why some test are falling.

these test are fixed now.

TODO:
I have added the Jacobian functionality for GeneralizedLorentz1D, SmoothBrokenPowerLaw which will compute the derivative of their function with respective to each parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants