Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable control_file_gen.pl to populate namelist parameters individually #1354

Open
jasonfleming opened this issue Jul 28, 2024 · 0 comments · May be fixed by #1355
Open

Enable control_file_gen.pl to populate namelist parameters individually #1354

jasonfleming opened this issue Jul 28, 2024 · 0 comments · May be fixed by #1355
Assignees
@jasonfleming
Labels
2024 bug compatibility Maintenance or improvements to support compatibility with external interfaces, APIs, or libraries configurability important non-critical modeling

Comments

@jasonfleming
Copy link
Collaborator

The availability and effect of namelist parameters has changed for different ADCIRC versions. Not all parameters should be populated with default values for a given namelist if the version of ADCIRC used with that fort.15 file does not support them. Currently, control_file_gen.pl populates all namelist values for each namelist for all versions of ADCIRC. The search-and-replace should be more granular so that only the parameters in the template are populated. Related to #228.
@jasonfleming jasonfleming added bug important non-critical compatibility Maintenance or improvements to support compatibility with external interfaces, APIs, or libraries configurability 2024 modeling labels Jul 28, 2024
@jasonfleming jasonfleming self-assigned this Jul 28, 2024
jasonfleming added a commit that referenced this issue Jul 28, 2024
@jasonfleming
resolves #1354
27db6df
@jasonfleming jasonfleming linked a pull request Jul 28, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonfleming jasonfleming

Labels
2024 bug compatibility Maintenance or improvements to support compatibility with external interfaces, APIs, or libraries configurability important non-critical modeling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enabling population of individual namelist parameters StormSurgeLive/asgs
1 participant
@jasonfleming