Make data file path configurable #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
1 task
Strajk
reviewed
Aug 19, 2023
programs/zwift-store-profile.mjs
Outdated
| @@ -7,7 +7,8 @@ import os from 'node:os'; | |||
| import jwtDecode from "jwt-decode"; | |||
| import { config } from 'dotenv'; | |||
|
|
|||
| const DATA_FILE_PATH = `${os.homedir()}/zwift-data.csv` // TODO: Make this configurable | |||
| const dataFilePath = process.env.ZWIFT_DATA_FILE_PATH; | |||
| const DATA_FILE_PATH = dataFilePath || `${os.homedir()}/zwift-data.csv` // TODO: Make this configurable | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the TODO "Make this configurable" in the "programs/zwift-store-profile.mjs" file. Currently, the data file path is hardcoded, but this PR makes it configurable by introducing a new environment variable.
Summary of Changes
const dataFilePath = process.env.ZWIFT_DATA_FILE_PATH;dataFilePathvariable instead of the hardcoded path:const DATA_FILE_PATH = dataFilePath ||${os.homedir()}/zwift-data.csv;These changes allow users to set the data file path by setting the
ZWIFT_DATA_FILE_PATHenvironment variable. If the environment variable is not set, the program falls back to the current hardcoded path.Please review and merge this PR at your earliest convenience.
Fixes #42.
To checkout this PR branch, run the following command in your terminal:
To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.