-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: error handling in factory contracts #6
Comments
Hi, I would like to contribute to solve this issue. I have been learning Cairo and I think I have the knowledge to solve it |
hey @machuwey i would love to work on this issue when the ODhack starts |
Is this issue still available? |
Hello @machuwey, May I handle this issue? I'm a Cairo developer |
@machuwey can i handle this task |
I'd be happy to do this. |
im a blockchian dev and i would like to work on this issue. can I be assigned to this |
May I work on this issue @machuwey ? My background: I am a web3 developer with 2 years of experience and a regular contributor at @keep-starknet-strange. I have been solving issues related to cairo for the past 2 months and I'm pretty confident that I can resolve this issue too. My approach: I would create a new struct as you showed the example of, review the entire codebase to handle all types of errors. eta: 3 days |
Could I be assigned to this? |
Hi, I am proficient Blockchain developer expert in Cairo , Rust ,Solidity and web development. |
Can I tackle this one? I'm a Software developer with over three years experience. I plan to properly go through the code and improve the error handling in factory contracts. |
I'd be happy to do this. |
Can I be assigned to this? |
I am Om Santoshwar, My Technical Skills- Experience- would solve this issue by using custom error that returns specific error messages for each enum case |
May I handle this issue? I will enhance error handling in the factory contract, define a custom error enum 'FactoryError' with specific error codes using the '#[error_code]' attribute, and replace generic errors with 'FactoryError' variants, such as AddressZeroOwner, UnAuthorizedCaller, DeploymentFailed, InvalidContractAddress, and others, to provide clearer error messages, standardized error handling, and improved contract security and reliability." |
Hi, I'm Ekene, a frontend and blockchain developer, and I’m new to the OnlyDust platform. This is my first time contributing to this repository, and I’m excited about the opportunity to collaborate and bring my skills to the table. To tackle this issue: I will implement a more structured approach using custom error codes. I will create an Errors module with an enum, such as FactoryError, where each error type will have its own code. For instance, I will define errors like AddressZeroOwner if the owner address is zero, UnAuthorizedCaller for unauthorized access, and DeploymentFailed if the contract deployment fails. By using custom error codes, I will make it easier to identify and track issues. These error codes will be tagged with #[error_code], ensuring they are clear and manageable. I will then go through the contract’s functions and replace generic error handling with these specific codes. |
I'd be happy to do this. |
Could I take on this issue? |
Is this issue still available? |
Let me handle this issue! |
Im agnik, a pytho dev, i also have experience with linux development and CI/CD, im learning cairo too, would love to take on this issue! |
hey sir I'd like to handle this task. |
Is it okay if I take this? |
Hello, can I be assigned this issue? My experience includes html, css, react, javaScript, typescript, solidity & Cairo. To solve this issue, I'll take the following the steps:
Kindly assign me please, I'm ready to work. |
Hey @machuwey, Aniruddha here. So I'm a typescript dev and also contributed in last odHack. Want to take up the issue and solve right away. Improve the factory contract error handling: Develop a centralized module entitled Errors, holding all possible failure scenarios with descriptive and unique error codes. Develop good checks against a general failure case, like zero-address owners, incorrect callers, and failures of deployment. Return meaningful error messages that will be useful for debugging and user feedback in case of errors. |
@machuwey Thank you for this opportunity, I will make a PR soon |
Improve error handling in
factory
contractConsider something like:
Instructions to apply
The text was updated successfully, but these errors were encountered: