Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.get(), .all(): allow search? #25

Open
wmertens opened this issue Nov 3, 2022 · 0 comments
Open

.get(), .all(): allow search? #25

wmertens opened this issue Nov 3, 2022 · 0 comments

Comments

@wmertens
Copy link
Collaborator

wmertens commented Nov 3, 2022

.all() is rarely used and has no parameters, so it would be a nice alias for .searchAll(attrs, options) when arguments are passed.

Likewise, .get() always has a scalar for the first argument, so if the first argument is an object, .get(attrs, options) could be an alias for .searchOne(attrs, options)

@Dzieni thoughts? One or the other or both or none?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant