-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create inverse_streetTalk() function (02/28/18) #10
Comments
LEX may be useful for #8. This is an intermediate step that only deals with text. |
@dmarulli very rough version of inverse_streetTalk() function has been pushed! The logic I use is to find the three datasets contain names of on_street, from_street and to_street. Then I find the intersections of these three sets and return an index in on_street. Finally return x,y in |
@YukunVVan okay, finally had a chance to look at the code--a lot of stuff in the works over here. Great stuff. Here are some comments:
|
Thanks for comments. Will try package |
For sure. Sounds good. |
@YukunVVan any questions or need any assistance? |
@dmarulli @patwater I have tried several methods to solve the fuzzy matching issue:
However, this function increases the running time. Use the method above cost 5s each search. If use With
Do you have any advice on how to utilize this function? What kind of fuzzy matching we're going to solve? |
Hmmmm this is a tricky tradeoff. Thanks for laying this out so clearly @YukunVVan . I am not sure how to handle the time speed though would note premature optimization is the root of all evil. In terms of operationalizing this, the API seems like the key path forward. How is #11 coming along @vr00n @dmarulli ? In terms of the threshold one, initial idea would be to set at 85. Note "west 8th" and Vallejo Villas" probably shouldn't be matched as there can often be a "street" and "avenue" with the same name. Both "Vallejo Villas Avenue" and "Vallejo Villas Street" in the same city though may not be the case here |
To clarify: The goal here is to be able to get the centroid of A suggestion is to lookup the intersection of So for
|
@vr00n Thanks for clarifying! I'm gonna update my code. |
This function should receive a street_name, a street_from, and a street_to; and return a lat/lng pair
The text was updated successfully, but these errors were encountered: