-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polling trigger #13
Comments
This might be best as a separate plugin. |
When would you use it otherwise? |
We could well have other providers that don't support webhooks (a generic |
Seems like it would make sense to add polling to those, instead of trying to build a generic polling plugin to handle all cases. Thoughts? |
Perhaps. What you envision the polling trigger would do? I was thinking it would just start a job periodically. |
I was thinking more along the lines of seeing if anything changed in a repo, maybe with an md5 checksum, and run only if it has. |
ok, yeah that sounds like it belongs here |
Maybe even just check the commit history.. |
+1 we're currently punching a hole in our firewall so our otherwise private build server can receive notifications from Github. Less than ideal. |
👍 |
I believe polling is not nice if you have a lot of repos, its better to use git post-commit or post-update hooks alongwith strider-cli , you may need to install it
|
That's fine if you're able (and happy) to expose your CI server to the On Saturday, 22 November 2014, arkoak [email protected] wrote:
James Gregory Tel: +61 (0) 411 619 513 |
You only need to expose it to your private git repo and it requires a login |
+1 ... @arkoak fine with your approach as an alternate (it would be better if there was an API rather than triggering a shell process, so the git repo could do "curl..." to ping strider server) -- but for me is much better to poll as currently running strider on node unaccessible from git server. I think this is an issue where both push and poll are each sometimes best. |
OTOH, in partial support of @arkoak, if you don't want to support polling internally, and don't want to expose your strider server, you can have a cron job on the strider server that does a git pull periodically, and then have post-update as suggested. Of course, internal support would be convenient. |
Hi |
@cerw your best bet is to use https://github.com/Strider-CD/strider-cli/#runtest |
Since plain git doesn't have any hooks, would be nice to add this feature.
The text was updated successfully, but these errors were encountered: