Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polling trigger #13

Open
knownasilya opened this issue Aug 12, 2014 · 17 comments
Open

Polling trigger #13

knownasilya opened this issue Aug 12, 2014 · 17 comments

Comments

@knownasilya
Copy link
Member

Since plain git doesn't have any hooks, would be nice to add this feature.

@jaredly
Copy link
Member

jaredly commented Aug 12, 2014

This might be best as a separate plugin.

@knownasilya
Copy link
Member Author

When would you use it otherwise?

@jaredly
Copy link
Member

jaredly commented Aug 12, 2014

We could well have other providers that don't support webhooks (a generic strider-mercurial, for example), and I don't think that polling would be vcs-dependent.

@knownasilya
Copy link
Member Author

Seems like it would make sense to add polling to those, instead of trying to build a generic polling plugin to handle all cases. Thoughts?

@jaredly
Copy link
Member

jaredly commented Aug 12, 2014

Perhaps. What you envision the polling trigger would do? I was thinking it would just start a job periodically.

@knownasilya
Copy link
Member Author

I was thinking more along the lines of seeing if anything changed in a repo, maybe with an md5 checksum, and run only if it has.

@jaredly
Copy link
Member

jaredly commented Aug 12, 2014

ok, yeah that sounds like it belongs here

@knownasilya
Copy link
Member Author

Maybe even just check the commit history..

@jagregory
Copy link

+1 we're currently punching a hole in our firewall so our otherwise private build server can receive notifications from Github. Less than ideal.

@yonjah
Copy link

yonjah commented Nov 6, 2014

👍

@arkoak
Copy link

arkoak commented Nov 22, 2014

I believe polling is not nice if you have a lot of repos, its better to use git post-commit or post-update hooks alongwith strider-cli , you may need to install it
npm install strider-cli
I have my git repos pushed to my strider server, Im using the following content in my post-update file in all git repos so whenever i push a changeset, it gets tested.

strider runTest -l <user> -p <password> -j <proj/name> -m git-update

@jagregory
Copy link

That's fine if you're able (and happy) to expose your CI server to the
world. A lot of us aren't in a position to do that.

On Saturday, 22 November 2014, arkoak [email protected] wrote:

I believe polling is not nice if you have a lot of repos, its better to
use git post-commit or post-update hooks alongwith *strider-cli *.
I have my git repos pushed to my strider server, Im using the following
content in my post-update file in all git repos so whenever i push a
changeset, it gets tested.

strider runTest -l -p -j <proj/name>-m git-update


Reply to this email directly or view it on GitHub
#13 (comment)
.

James Gregory

Tel: +61 (0) 411 619 513
Website: http://jagregory.com
Twitter: @jagregory http://twitter.com/jagregory

@arkoak
Copy link

arkoak commented Nov 23, 2014

You only need to expose it to your private git repo and it requires a login
to trigger, if your git repo hooks are secure enough, I don't see a
problem with this approach

@shaunc
Copy link

shaunc commented Nov 30, 2014

+1 ... @arkoak fine with your approach as an alternate (it would be better if there was an API rather than triggering a shell process, so the git repo could do "curl..." to ping strider server) -- but for me is much better to poll as currently running strider on node unaccessible from git server. I think this is an issue where both push and poll are each sometimes best.

@shaunc
Copy link

shaunc commented Nov 30, 2014

OTOH, in partial support of @arkoak, if you don't want to support polling internally, and don't want to expose your strider server, you can have a cron job on the strider server that does a git pull periodically, and then have post-update as suggested. Of course, internal support would be convenient.

@cerw
Copy link

cerw commented Apr 28, 2015

Hi
so is there a hook that can trigger test/deploy? Really need this :)

@knownasilya
Copy link
Member Author

@cerw your best bet is to use https://github.com/Strider-CD/strider-cli/#runtest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants