Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not support secure transport #2

Open
kfatehi opened this issue Sep 13, 2014 · 2 comments
Open

Does not support secure transport #2

kfatehi opened this issue Sep 13, 2014 · 2 comments

Comments

@kfatehi
Copy link
Member

kfatehi commented Sep 13, 2014

Conventionally, mail sent on port 465 uses TLS, however strider-mailer does not have a way to enable secure transport.

In index.js there are two objects, smtpTransport and smtpConfig which together orchestrate nodemailer. The smtpTransport option could be modified per https://github.com/andris9/nodemailer-smtp-transport#usage to have {secure: true} if the port is 465.

Either that or we expose more configuration to the user through ENV

ref Strider-CD/strider#570

@knownasilya
Copy link
Member

Is that the expected behavior? For it to be secure when on port 465?

@kfatehi
Copy link
Member Author

kfatehi commented Sep 14, 2014

That seems to be the convention as far as I've seen it in configs, etc, but I'd like a 2nd opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants