Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions #3

Open
domehead100 opened this issue May 17, 2020 · 1 comment
Open

Suggestions #3

domehead100 opened this issue May 17, 2020 · 1 comment

Comments

@domehead100
Copy link

Hi Federico,

This was very helpful. Here are a couple of suggestions to limit possible frustration from people trying out your demo who may not be too familiar with the javascript build environment. Typically it is bad practice to install typescript and webpack globally, so users may not have them installed globally (and should not actually).

  • tsc may not be in the command line or may not be a current version. I would add npm install --save-dev typescript so that typescript and tsc are stored within the project. They will be in the ./node_modules/.bin folder. You may want to write a .bat file and/or .sh so that the user can follow your instructions. tsc may be in the path but an old version, e.g., v1 installed by visual studio for .net users
  • webpack may not be in the path or may be an incorrect version stored globally, so a .bat or .sh that launches it might help prevent frustration

Also:

  • your grammar complains about errors from the blank lines between the input, calcs, and outputs sections (I added eol* blocks in between these to get it to stop complaining)

That's about it. Thanks, again very helpful.

@ftomassetti
Copy link
Member

Hi Michael, this is really helpful. I took note and I will update the code and the article when I manage. I will also consider this for future articles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants