Shivam: Timers Wrapper Code Review #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated Project Linker Settings to enable newlib support for proper compilation of new and delete operators. - Various updates and test changes
…C++' into Chris/OuroborosC++
…icsSoftware into Chris/OuroborosC++
- Confirmed working on flightboard, LED blinks correctly. - Note about code auto-gen: you MUST change the main.cpp to main.c, then change the .ioc file and save, then change this back. This should be automated in the makefile or in a script later.
…icsSoftware into Chris/OuroborosC++
- Tasks should now follow design similar to UARTTask (call into a Run() function from a RunTask() static so the task counts as part of the instance) - Various fixes to the code, like initializing static variables
cjchanx
commented
Oct 15, 2022
cjchanx
commented
Oct 15, 2022
cjchanx
commented
Oct 15, 2022
Components/Core/Inc/Timer.hpp
Outdated
| bool ChangePeriod(const uint32_t period); | ||
|
|
||
| bool ChangePeriod(const uint32_t period_ms); | ||
| bool StartTimer(); |
There was a problem hiding this comment.
Rename these to Start() and Stop()
There was a problem hiding this comment.
It's implied that it's a timer operation
cjchanx
commented
Oct 15, 2022
Components/Core/Timer.cpp
Outdated
| bool Timer::ChangePeriod(const uint32_t period_ms) | ||
| { | ||
| if (xTimerChangePeriod(rtTimerHandle, MS_TO_TICKS(period_ms), DEFAULT_TIMER_COMMAND_WAIT_PERIOD) == pdTRUE) { | ||
| StopTimer(); |
There was a problem hiding this comment.
Recommend making this directly call xTimerStop, and also check if that returns pdTRUE
cjchanx
commented
Oct 27, 2022
cjchanx
commented
Oct 27, 2022
| if (xTimerStop(rtTimerHandle, DEFAULT_TIMER_COMMAND_WAIT_PERIOD) == pdPASS) { | ||
| timerState = PAUSED; | ||
| return true; | ||
| } |
There was a problem hiding this comment.
add an else here to account for if we failed xTimerStop (for whatever reason)
|
New Pull Request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leave as draft pull request please, in the future open a pull request to request for review (but we haven't gone through this yet so I've done it this way for now 😄)