-
Notifications
You must be signed in to change notification settings - Fork 51
(GitHub Toggle Code Wrap) Inline file action button and context-menu cut #66
Comments
Hi @jerone! Hmm, yeah that's going to be a difficult fix. The file action button and the code table are siblings. If we add the following to remove the .ghd-code-wrapper {
overflow: unset !important;
}
.ghd-wrap-table {
overflow-x: auto !important;
} It looks okay until you toggle the wrap Another alternative would be to move the block to the right, but then it overlaps the line number. .BlobToolbar {
left: 2px !important;
} What do you think? cc: @silverwind @the-j0k3r |
And what if you add the |
Adding overflow to the table or sibling won't work. Only a parent of the table. The easiest solution, which is what I went with, was to move the |
Hi @Mottie, The solution makes the menu visible again. But it has a side-effect, menu and selected lines are not aligned anymore: Test with wrapping on: https://github.com/StylishThemes/GitHub-Dark-Script/blob/master/github-script-code-wrap.user.js#L203 |
Hmm, I included CSS to move the menu down. Is the |
It is: |
It's not GitHub Refined or any other UserScript. When wrapping is disabled the button aligns perfect. But when when wrapping is enabled, then the offset happens. It's exactly off by the 2 lines above where wrapping happened. |
Hmm, I can't reproduce that. I usually keep the wrapping enabled so it was aligned while I was testing. I just set the default to be disabled and the menu stayed on the correct line. |
The |
@Mottie commented on Jul 7, 2019, 2:06 PM GMT+2:
No, just tried. Maybe you missed my edit:
|
Ahh, ok I see it now... when you select a line that wraps, it aligns properly. If a non-wrapping line is selected, then the menu appears 2 lines above. |
I can reproduce it also the otherway around:
|
Ugh. GitHub's code positions that menu by setting a |
:) Otherwise your other solution will do with some more padding to the line-numbers:
|
The inline file action button and context-menu is cut:
Correct (with "GitHub Toggle Code Wrap" disabled):
See it in action here:
https://github.com/StylishThemes/GitHub-Dark-Script/blob/master/github-script-code-wrap.user.js#L203
That is also the offending line of code, causing this issue.
The text was updated successfully, but these errors were encountered: