Skip to content
This repository has been archived by the owner on Jun 20, 2020. It is now read-only.

titles not readable when they included links #73

Open
hodbauer opened this issue Nov 13, 2019 · 6 comments
Open

titles not readable when they included links #73

hodbauer opened this issue Nov 13, 2019 · 6 comments
Labels

Comments

@hodbauer
Copy link

  • Browser: Chrome 78.0.3904.97
  • Operating System: Windows 10 Home
  • Link to page with the issue: changing-a-commit-message
  • Screenshot:
    image

as we can see in the screenshot there is a title that i half marked (ended with pushed online).
I didn't find any overwrite css selector that fix it when the title is h4, a few rows above there is h3 title that (i think) by github have another css selector.

@the-j0k3r
Copy link
Member

Hello and thanks for reporting this issue to us.

Can you please force a style update check (not a script update check) to ensure you have the latest Github Dark version installed. thanks.

@hodbauer
Copy link
Author

Can you please force a style update check

I will glad to do that.
Could you please explain to me how to do that? a hard reload of the page? (Ctrl + Shift + R)

@the-j0k3r
Copy link
Member

See https://github.com/StylishThemes/GitHub-Dark-Script#screenshot
Look at the bottom left {Force Update style ^]

@hodbauer
Copy link
Author

I've pressed this button (without any change in the settings).
Then I reload the specific page and there is no changes about this bug.

@the-j0k3r
Copy link
Member

the-j0k3r commented Nov 13, 2019

Sorry that it didn't help, only thing I can suggest is to use Stylus + GitHub Dark usercss https://github.com/StylishThemes/GitHub-Dark#installation (works fine here) or wait for someone that understands the script to reply.

@Mottie
Copy link
Member

Mottie commented Nov 13, 2019

This is definitely a script bug.

It looks like when we wrote GitHub Dark Script, we didn't anticipate the script including additional @-moz-document rules:

So right now, all of the rules after the first one are being added as-is. This doesn't work because document rules were never part of Chrome & deprecated in Firefox.

To fix this will require a big rewrite of the GHD script. I may not have time to do it, unless I find some free time over the weekend or @silverwind finds some time.

Quick solution: install Stylus and GitHub Dark usercss.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants