Give users more changeable colors

[sukerokushin]

I feel like this extension could be tuned to perfection if we could change the colors of stuff like the background itself (table heading text color, table heading bg color, etc.) through the "Manage style" UI. I imagine that, for some, the default colors have too strong of a contrast. I don't think it'd be out of your way, and would at the very least service my needs :P

[the-j0k3r]

@kfdz277 That you for this request.

I don't think it'd be out of your way

The bad news.

It would and not something anyone wants to tackle to service the needs of a couple of users due to complexity of style, how its written and the sheer number of issues we need to get past before going down any route like this, not a simple matter at all.

The good news.

It probably would be possible to override some elements in a new smaller style (we have done that for Github Dark a few times) that would work along side this style, thats more likely to happen and easier to tackle, but that said, if you really want something like that, youll need to wait for someone )even me) to be interested in doing this.

So anyone interested in this please thumbs up this comment (mine) so I can gauge interest. in this request.

@AfroThundr3007730 ping what say ye.

Thanks for understanding.

[sukerokushin]

How about the regular font color? I would never have guessed that it was actually complicated though lol, totally understand your apprehension. My main issue is that the background and the font don't have enough contrast, so it comes off as being hard to read.

[the-j0k3r]

If you give me specific for instances in screenshots and links to pages I'll try to do an override style, but again its not as simple as adding the options to existing style, because we dont organize just font color rules, one rule can have text color and other elements colors also, so these would need to be separated not to mention text colors are in several places with several shades of white, for different wiki based sites. So it has to work

Its easier and faster to override in a small style that re-writing most of the style to add options and not fix the actual issues behind in a huge OLD style like this. So provide the info I need and Ill try to make an override style when I have a minute.

[AfroThundr3007730]

I think that providing support for user configuration inline would basically require a complete rewrite of the desktop style. Not that it would be too difficult, just time consuming, and we'd be playing unstyled element whack-a-mole for a few weeks afterwards. The majority of the rules in this style are from those accumulated fixes anyway. A rewrite may be the proper way ahead with this though, for future sustainability.

As far as doing it in a separate style, that's certainly possible, but we'll end up writing ridiculous selectors in an attempt to override all the !important rules sprinkled everywhere, much as we have to do now in the main style. This would require the least ammount of immediate effort though.

[the-j0k3r]

We already have https://github.com/StylishThemes/Feature-Override-Styles so I can start converting the styles we already have for GitHub Dark

Something to solve this would go in there. Under the premise that it will be possible to override the the text colors.

Further reading StylishThemes/GitHub-Dark#1008

[the-j0k3r]

@kfdz277 See https://raw.githubusercontent.com/StylishThemes/Feature-Override-Styles/master/wikipedia-dark-gray-text-colors.user.css

That may improve in the future but for now its text colors only.

Any contributions welcome.

[the-j0k3r]

@kfdz277 feedback on the script above?

[sukerokushin]

I definitely dig this, sorry for being late. Much easier on the eyes imo.

[the-j0k3r]

@kfdz277 see #123, Please avoid in future reporting new unrelated issues in existing issues.

New issues for these are the way to go.

Thanks

[sukerokushin]

i posted here bc i thought the style you gave me was breaking these as opposed to it being part of the core lol sorry

[the-j0k3r]

You should test first with the wikipedia-dark-gray-text-colors.user.css and then without to determine where the issue is, then open an issue in the relevant repo.

Also for the background colors see #119 it has a workaround you may like to use.