-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Too much padding in a custom list view #18
Comments
It's looking pretty well on Windows. Default themeDAneo OriginSure you have the latest release and no overrides anywhere? None of the few OS specific rules themes related with this issue. The following rule is responsible to remove all row paddings for overlay controls with kind info. Theme-DAneo/themes/DAneo Base.hidden-theme Lines 1165 to 1171 in 642f43a
That's important as padding is controlled by symbol_container or kind_container in this case. |
Using latest version and no relevant overrides. I went and investigated a little and the rule you've pointed out didn't make any difference but this one did: Theme-DAneo/themes/DAneo Base.hidden-theme Lines 1150 to 1156 in 642f43a
With |
That's the basic rule, which is applied to all quick panels. Your change would end up in all non-kind_info containing quick panels' rows to have no padding. It should be overridden by the one I've linked. Could you enable It should look as follows:
1st line is important: |
So you don't see any differences in padding between the "Goto diagnostic" and the native "Goto Symbol in Project"? |
Nope |
But I can barely remember a ST bug, which caused |
|
Exactly the bug: |
I'll take the liberty of pinging @BenjaminSchaaf instead of pinging the issue. |
It is wrong when triggering the command using key binding: {
"keys": ["shift+f8"]
"command": "lsp_goto_diagnostic",
} or through the main menu ( It looks fine when using The command palette entry is: {
"caption": "LSP: Goto Diagnostic",
"command": "lsp_goto_diagnostic",
}, (actual entry also includes "args" but I've reproduced without it too) Code of the command: https://github.com/sublimelsp/LSP/blob/2a7b3bae8ae2d47cff58e7e7f5ebb16eebdf304e/plugin/goto_diagnostic.py#L36-L78 |
Can reproduce it with your steps on Windows as well. With |
On Mac, build 4134, DAneo Elegant.
The LSP "Go to diagnostic" panel looks like this here:
Note how much padding each item has. I feel that it's too much and it wastes quite a bit of useful space that could be otherwise used to avoid scrolling (especially with smaller window sizes).
As an example this is the built-in "Goto Symbol in Project" using DAneo. There is much better IMO:
And for reference, this is "Go to diagnostic" in adaptive theme:
The text was updated successfully, but these errors were encountered: