Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize trailing_spaces_include_current_line #42

Closed
sampumon opened this issue Mar 29, 2013 · 3 comments · May be fixed by #43
Closed

Sanitize trailing_spaces_include_current_line #42

sampumon opened this issue Mar 29, 2013 · 3 comments · May be fixed by #43

Comments

@sampumon
Copy link

Fix { "trailing_spaces_include_current_line": false } so that the hilighting of current line is toggled off only when you start editing that line. Or even better, only when start editing at the end of line.

This way, when manually deleting trailing spaces, the hilighting would not disappear just when you're about to delete it (because of entering that line).

When fixed, make { "trailing_spaces_include_current_line": false } the default.

Btw. instead of providing "a lot of options to fine-tune the way you want to decimate trailing spaces", I'd prefer to not have options, just sane default ones :)
@chikamichi
Copy link
Contributor

Hi,

The way it works in unpaid open-source, is you not to be requiring me to fix things, but rather creating a pull request. If you are not able to do so, reporting the issue in a friendly fashion is also highly valuable. So, no, there will be no such things as this "Fix foo. When foo fixed, make bar." bullshit with me.

Please consider rephrasing your underlying feature request (many examples available in this very issue tracker, filled with kind words from all over the word), or just, well, be so kind as to STFU ^^

sampumon added a commit to sampumon/TrailingSpaces that referenced this issue Mar 31, 2013
@sampumon
unhilight_editing_line: unhilight current line when in "edit mode"
5f19dca 
Set "trailing_spaces_unhilight_editing_line": true to enable.
Does its thing only if "trailing_spaces_include_current_line" is true.

Fixes SublimeText#42.
@sampumon sampumon mentioned this issue Mar 31, 2013
Open
@sampumon
Copy link
Author

Huh, it seems I was in wrong mode when writing the issue. Sorry about that!

I do think that my friendliness was about average. Example from other issues here: "Make HIDE_ON_MINIMAP a setting. As the title say." Ok it was yours :) Still, I was just being unambiguous about what I want. Rephrasing would mean changing "fix" into "can you change … so that …", and "when fixed" into "if that is possible, would it be ok to then …". Which just makes it harder to understand the point.

Maybe I was also thinking that you, having made the plugin, would take just 1/10 of time (~5 hours) to do the thing. And not all open source like pull requests. They might even end up nitpicking about minor style issues, and never accept the request. Didn't check what's the spirit here, though.

Anyway! I sent the pull request. Making a Sublime plugin was on my semitodo-list, so all's good! Greetings from Helsinki ♥

@chikamichi
Copy link
Contributor

Words do matter. They don't make it harder to understand your point if you know which one to pick and care for them. Many among us show disregard for good communication, but here's the secret: behave and/or talk like a jerk, and then you "are" one, even though you sincerely think you were not. This is the Cognitive Bias, and there is nothing you can do against it, so pay attention, fellow contributor!

Thanks for the pull request, I'll review it when I have the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unhilight current line when in "edit mode" sampumon/TrailingSpaces
2 participants
@chikamichi @sampumon