Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan.trial_period_days can be None, yet plan_card.html attempts math on trial_period_days #1315

Closed
chrisjsimpson opened this issue Mar 10, 2024 · 0 comments

Comments

@chrisjsimpson
Copy link
Contributor

chrisjsimpson commented Mar 10, 2024

Is your feature request related to a problem? Please describe.

plan.trial_period_days can be None, yet plan_card.html attempts math on trial_period_days.

subscribie/themes/theme-jesmond/jesmond/macros/plan_card.html", line 23, in template\n    {% if plan.trial_period_days > 0 %}\n    ^^^^^^^^^^^^^^^^^^^^^^^^^\nTypeError: \'>\' not supported between instances of \'NoneType\' and \'int\

Describe the solution you'd like

Default plan.trial_period_days to 0 and/or update template to be more robust.

Describe alternatives you've considered

Additional context
Consider both existing and new shops data modem / data migrations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant