Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an operator, all plans are not iteration on application startup (performance) #1398

Closed
chrisjsimpson opened this issue Aug 28, 2024 · 2 comments
Labels
released This issue/pull request has been released.

Comments

@chrisjsimpson
Copy link
Contributor

Is your feature request related to a problem? Please describe.

# since there is danger here that newly created pricelists may be added # noqa: E501
for plan in plans:
# Note we are careful to skip plans which already have a PriceList attached # noqa: E501
# to handle the case of an already updated shop.
if len(plan.price_lists) == 0:
for price_list in price_lists:
log.debug(
f"Adding price_list {price_list.name} to {plan.title}"
)
plan.price_lists.append(price_list)
database.session.commit()
log.debug(f"Added price_list {price_list.name} to {plan.title}")

Is no longer needed and should be removed.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Copy link

🚀 Issue was released in v0.1.204 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Aug 28, 2024
Copy link

🚀 Issue was released in v0.1.204 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

No branches or pull requests

1 participant