Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation needs completion #55

Open
joelebwf opened this issue Dec 3, 2018 · 2 comments
Open

Validation needs completion #55

joelebwf opened this issue Dec 3, 2018 · 2 comments
Milestone

Comments

@joelebwf
Copy link
Collaborator

joelebwf commented Dec 3, 2018

Validation needs to be completed. It is not entirely defined how comprehensive validation needs to be on the first release of pyoblib so a good starting point is to complete a design conversation on this issue and update this ticket. With this said the intent of the pyoblib validator is to validate to the Solar Taxonomy XSD, not to validate advance business rules (use Xule instead) so the design should at least cover XSD basics (data type checks for instance).

@cwhanse
Copy link
Collaborator

cwhanse commented Dec 18, 2018

What I heard on the call today are two use cases for oblib.validator:
1 - oblib.Parser.from_xml_string can call validator.xxxxx to confirm that the read-in values are appropriate for setting to an Entrypoint
2 - oblib.data_model.XXXXXX.set( , value) methods can call validator.xxxxx to confirm that value is appropriate for the target.
Please correct or clarify.

michael-bbs added a commit to michael-bbs/pyoblib that referenced this issue Jan 10, 2019
michael-bbs added a commit to michael-bbs/pyoblib that referenced this issue Jan 11, 2019
@joelebwf joelebwf added this to the v1.0.0 milestone Jan 22, 2019
@joelebwf
Copy link
Collaborator Author

Please decide how far we are going to take Validation on 1.0.0 and add the rest of the validation to 1.1.0 and then close this issue.

joelebwf added a commit to joelebwf/pyoblib that referenced this issue Feb 27, 2019
@cwhanse cwhanse modified the milestones: v1.0.0, v1.1.0 Mar 6, 2019
@joelebwf joelebwf modified the milestones: v1.1.0, 1.2.0 Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants