Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Projects not saved in user defined 'Documents' folder #171

Open
rob-fi opened this issue Oct 8, 2023 · 2 comments
Open

Windows: Projects not saved in user defined 'Documents' folder #171

rob-fi opened this issue Oct 8, 2023 · 2 comments
Labels
bug Something isn't working Help / Contributions welcome Noone is actively working on this right now, feel free to submit a Pull Request Windows App

Comments

@rob-fi
Copy link

rob-fi commented Oct 8, 2023

Describe the bug
SuperConductor assumes that the user's Documents folder under Windows is the default %userprofile%\Documents even though Windows allows a user to set the location arbitrarily.

To Reproduce
Steps to reproduce the behavior:

  1. Set Windows Documents folder to a location other than the default via Right clicking Documents (under This PC or via the Quick Access in Explorer) -> Properties -> Location
  2. Launch SuperConductor
  3. Observe it create a directory under %userprofile%\Documents

Expected behavior
SuperConductor uses the Windows Known Folders GUID/CLSID to determine the real path of the user's Documents folder so that if the user has changed the default loction, the project files are stored in the correct place.

Desktop (please complete the following information):

  • OS: Windows 10
  • Version (latest)

Additional context
Microsoft documentation:
https://learn.microsoft.com/en-gb/windows/win32/shell/known-folders
https://learn.microsoft.com/en-gb/windows/win32/shell/knownfolderid
https://www.tenforums.com/tutorials/3123-clsid-key-guid-shortcuts-list-windows-10-a.html
(I am not a (real) developer so I'm not sure which approach should be used)

@rob-fi rob-fi added the bug Something isn't working label Oct 8, 2023
@nytamin
Copy link
Member

nytamin commented Oct 9, 2023

Thanks for pointing this out.
Currently SuperConductor is using the nodejs cross-platform os.homedir() API to determine where to store the project files, here.
If there is a better way to retrieve the file path in nodejs I think we could change it.
It's not being actively looked into currently, but Pull Requests are welcome!

@nytamin nytamin added the Help / Contributions welcome Noone is actively working on this right now, feel free to submit a Pull Request label Oct 9, 2023
@rob-fi
Copy link
Author

rob-fi commented Oct 9, 2023

I had a little look into what might be involved in Nodejs, didn't find too much other than this post from a few years back:

https://stackoverflow.com/questions/50391150/how-to-get-known-windows-folder-path-with-node

That's a tricky one, I'm sure you'd rather have as little platform-specific fudging going on as possible. Especially when it's to solve an issue for what I would assume would be a small number of users. I've observed other projects just use dot folders on Windows also, but that is much more confusing to the average user I'd argue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Help / Contributions welcome Noone is actively working on this right now, feel free to submit a Pull Request Windows App
Projects
None yet
Development

No branches or pull requests

2 participants