-
-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add + Overlay new bomb tick sound (4s) onto existing fizz.wav #2637
base: master
Are you sure you want to change the base?
Conversation
Added bomb tick sound (plays for 4s), and gradually but systematically increases in tempo to alert the player of an impending explosion from the bomb enemy. This is to be overlaid/played in conjunction with the first instance of fizz.wav being played (This needs coding).
Since this is a file name change, I'm certain it will require code changes. |
This is not a file name change. The two sounds, tick.ogg and fizz.wav should be played simultaneously while the bomb is readying to explode. The code would be to make these play in conjunction. I understand the fizz.wav repeats on a loop so the bomb tick would just need to be played once. |
bomb.tick.with.fizz.github.1.mp4
to do:
|
Would it not be smarter to make the sound file be a single “beep” and play it several times depending on how long the ticking phase is? |
I think the several beeps, which give a sense of tempo, makes it more intuitive as to when the bomb is about to explode. Single beeps would not be as useful of information to the player, just indicating when the animation is changing in frequency. But now that you mention it, I could fit the tempo changes to when the animation increases in frequency - can you give details on the length of each phase and how many flashes there are? |
Playing short sound multiple times may (and definitely will) introduce some sort of lag. It is better to adjust animation speed to sound length. |
Currently not at home. I can tell you later. Perhaps making two sound files then (one for each flash intensity) and divide the action in two? That way we can play each sound based on each phase but also have control over how long either phase should be (should changes be made there) are and the sound still lining up |
tick.ogg is one sound file - unsure how this will create lag? besides, we're not talking about increasing the amount of short sounds - i could decrease the tempo, which would actually mean less "short sound[s]" are played within a space of time. making two sound files is probably best - more bomb types are being added to the game, which im assuming have differing fuse lengths with different length phases...? hmm |
What I meant is playing one short file multiple times, not that sound data contains short beeps lol. |
Yes. Most likely Rusty Bomb and, perhaps, Old Bomb get a much shorter ticking time. Also Haywire and Hellbent don’t have a faster ticking phase so having two sound files also works great with them |
Added bomb tick sound (plays for 4s), and gradually but systematically increases in tempo to alert the player of an impending explosion from the bomb enemy.
This is to be overlaid/played in conjunction with the first instance of fizz.wav being played (This needs coding). Idk how to do that, so some small help would be appreciated 👍