Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add + Overlay new bomb tick sound (4s) onto existing fizz.wav #2637

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Alasdairbugs
Copy link
Contributor

Added bomb tick sound (plays for 4s), and gradually but systematically increases in tempo to alert the player of an impending explosion from the bomb enemy.

This is to be overlaid/played in conjunction with the first instance of fizz.wav being played (This needs coding). Idk how to do that, so some small help would be appreciated 👍

Added bomb tick sound (plays for 4s), and gradually but systematically increases in tempo to alert the player of an impending explosion from the bomb enemy.

This is to be overlaid/played in conjunction with the first instance of fizz.wav being played (This needs coding).
@Alasdairbugs Alasdairbugs added status:in-progress Progress has been done, but more is intended be done category:code good first issue Good for first-time contributors labels Sep 15, 2023
@Alasdairbugs Alasdairbugs added this to the 0.7.0 milestone Sep 15, 2023
@bruhmoent
Copy link
Member

Since this is a file name change, I'm certain it will require code changes.

@Alasdairbugs
Copy link
Contributor Author

This is not a file name change. The two sounds, tick.ogg and fizz.wav should be played simultaneously while the bomb is readying to explode.

The code would be to make these play in conjunction.

I understand the fizz.wav repeats on a loop so the bomb tick would just need to be played once.

@mrkubax10 mrkubax10 added type:feature status:needs-review Work needs to be reviewed by other people and removed status:in-progress Progress has been done, but more is intended be done good first issue Good for first-time contributors labels Sep 16, 2023
@Alasdairbugs
Copy link
Contributor Author

bomb.tick.with.fizz.github.1.mp4
  • fizz.wav plays once (unsure how I feel about this, give opinion via video)
  • the tick sound ends about 0.4s short (does anyone know how long the bomb is fused for before exploding?). I can adjust this.

to do:

  1. make the tempo for the tick sound to be longer to better fit the fuse length,
  2. discuss if the fizz.wav should be continuously played during the tick noise (i think it should, im pretty sure this is what it used to be).

@Rusty-Box
Copy link
Member

Would it not be smarter to make the sound file be a single “beep” and play it several times depending on how long the ticking phase is?

@Alasdairbugs
Copy link
Contributor Author

I think the several beeps, which give a sense of tempo, makes it more intuitive as to when the bomb is about to explode. Single beeps would not be as useful of information to the player, just indicating when the animation is changing in frequency.

But now that you mention it, I could fit the tempo changes to when the animation increases in frequency - can you give details on the length of each phase and how many flashes there are?

@mrkubax10
Copy link
Member

mrkubax10 commented Sep 17, 2023

Playing short sound multiple times may (and definitely will) introduce some sort of lag. It is better to adjust animation speed to sound length.

@Rusty-Box
Copy link
Member

Currently not at home. I can tell you later. Perhaps making two sound files then (one for each flash intensity) and divide the action in two? That way we can play each sound based on each phase but also have control over how long either phase should be (should changes be made there) are and the sound still lining up

@Alasdairbugs
Copy link
Contributor Author

tick.ogg is one sound file - unsure how this will create lag? besides, we're not talking about increasing the amount of short sounds - i could decrease the tempo, which would actually mean less "short sound[s]" are played within a space of time.

making two sound files is probably best - more bomb types are being added to the game, which im assuming have differing fuse lengths with different length phases...? hmm

@mrkubax10
Copy link
Member

What I meant is playing one short file multiple times, not that sound data contains short beeps lol.

@Rusty-Box
Copy link
Member

making two sound files is probably best - more bomb types are being added to the game, which im assuming have differing fuse lengths with different length phases...? hmm

Yes. Most likely Rusty Bomb and, perhaps, Old Bomb get a much shorter ticking time. Also Haywire and Hellbent don’t have a faster ticking phase so having two sound files also works great with them

@mrkubax10 mrkubax10 added the status:needs-work In progress, but no one is currently working on it (New volunteers welcome) label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code status:needs-review Work needs to be reviewed by other people status:needs-work In progress, but no one is currently working on it (New volunteers welcome) type:feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants