Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with unisolid tiles and frozen enemies #2933

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Brockengespenst
Copy link
Contributor

@Brockengespenst Brockengespenst commented May 6, 2024

Addresses the following topics:

  • Tux can duck and stand up if he wouldn't hit his head on the unisolid tile.
  • Bouncy Snowballs keep moving normally when inside an unisolid tile hitbox.
  • Tux stands normally on top of a frozen enemy.
  • Frozen enemies don't do anything to buttons

Fixes #2929

@Brockengespenst Brockengespenst changed the title Fix some unisolid issues Fix issues with unisolid tiles and frozen enemies May 7, 2024
@Brockengespenst Brockengespenst marked this pull request as ready for review May 7, 2024 16:12
@Brockengespenst
Copy link
Contributor Author

These changes should fix all mentioned issues in #2929.
I changed the collision group of the PushButton to static, I guess this makes more sense. Also it prevents the PushButton to be pushed away a bit by throwing frozen enemies at it. If this behavior was intended, please let me know.

@Rusty-Box
Copy link
Member

I changed the collision group of the PushButton to static, I guess this makes more sense. Also it prevents the PushButton to be pushed away a bit by throwing frozen enemies at it. If this behavior was intended, please let me know.

Finally, no more pushing the push(hihi)button around! 🎉

@Brockengespenst
Copy link
Contributor Author

Just one thought: If standing on a frozen enemy - should it be treated like ice such that it is a bit slippery?

@Eauix
Copy link
Contributor

Eauix commented May 8, 2024

Just one thought: If standing on a frozen enemy - should it be treated like ice such that it is a bit slippery?

This could be interesting, as it'd make more sense afterall. Speaking of this, I have an idea for a little change on the physics of frozen enemies, they could be thrown just like a Mr. ice cube or a snail, but break on impact with a wall. As of now the frozen enemy acts only like a rock that can be destroyed, which imo is kinda lame. They could still be put on the ground by releasing it while ducking

@mrkubax10 mrkubax10 added category:code status:needs-review Work needs to be reviewed by other people involves:physics type:bugfix Pull Requests that fix bugs. labels May 11, 2024
@Brockengespenst
Copy link
Contributor Author

Does anyone else want to share an opinion?

@weluvgoatz weluvgoatz added this to the 0.7.0 milestone Jun 1, 2024
@weluvgoatz weluvgoatz self-requested a review June 1, 2024 22:52
@Brockengespenst Brockengespenst force-pushed the fix_some_unisolid_issues branch from 238329b to 3ecc1c5 Compare June 24, 2024 20:33
@Brockengespenst Brockengespenst force-pushed the fix_some_unisolid_issues branch from 3ecc1c5 to 1d70137 Compare July 2, 2024 18:06
@Rusty-Box
Copy link
Member

Speaking of this, I have an idea for a little change on the physics of frozen enemies, they could be thrown just like a Mr. ice cube or a snail, but break on impact with a wall.

I do like that. Gives the ice flower even more offensive options.

Copy link
Member

@Rusty-Box Rusty-Box left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@Frostwithasideofsalt
Copy link
Member

Just one thought: If standing on a frozen enemy - should it be treated like ice such that it is a bit slippery?

This could be interesting, as it'd make more sense afterall. Speaking of this, I have an idea for a little change on the physics of frozen enemies, they could be thrown just like a Mr. ice cube or a snail, but break on impact with a wall. As of now the frozen enemy acts only like a rock that can be destroyed, which imo is kinda lame. They could still be put on the ground by releasing it while ducking

While this does sound fun, i think it might make the ice flower a bit overpowered. If that gets done, something else about the ice flower should be nerfed to compensate. My initial idea is to reduce the amount of shots the ice flower can shoot at a time to one, but that sounds kinda lame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code involves:physics status:needs-review Work needs to be reviewed by other people type:bugfix Pull Requests that fix bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange interactions with Unisolid Tiles and Frozen Enemies
6 participants