Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it independent from swspotify. #9

Open
xatuke opened this issue Sep 6, 2020 · 8 comments
Open

Make it independent from swspotify. #9

xatuke opened this issue Sep 6, 2020 · 8 comments

Comments

@xatuke
Copy link

xatuke commented Sep 6, 2020

Why?

img

Where?

img

How to fix senpai?

img

How actually?

Write the same requests which are used for getting the lyrics on swaglyrics cli on the chrome extension, ez fix.

@aadibajpai
Copy link
Member

@flabbet I know we should do this eventually but this also involves making a nice UI on the right and rewriting the swaglyrics core in JS.

thoughts?

@flabbet
Copy link
Member

flabbet commented Sep 6, 2020

we could do that, but it's a bit of work and I don't have time and will to do that. Let's make it hacktoberfest thing and let people do that

@aadibajpai
Copy link
Member

If you'd like to work on this, a UI like Netflix Party would be very interesting. Even SwagLyrics on Firefox Side View looks pretty nice w/o the extra scrollbars and stuff.

image

@flabbet
Copy link
Member

flabbet commented Sep 6, 2020

Sure, but this is not what extension is for

@flabbet
Copy link
Member

flabbet commented Sep 6, 2020

The extension is a bridge for SwagLyrics-For-Spotify, so it can support the Spotify browser. This is not a good idea to make console lyrics.

@aadibajpai
Copy link
Member

I agree with @flabbet here, @crowded-geek. Your issue is actually two separate things,

bug: the chrome extension spams local requests which floods network logs

feature request: standalone version of the chrome extension

now this isn't the same thing since SwSpotify is consumed by other python libraries as well which might wish to use the extension to extend support for Spotify Web.

so even if we implement a standalone version, I don't think we can stop the bug.

@xatuke
Copy link
Author

xatuke commented Sep 10, 2020

The fact still stays that the chrome extension doesn't need to use SwSpotify. I have no idea why was it connected to it in the first place. We can just scrape the current song data from the spotify tab, get lyrics and show them.

@aadibajpai
Copy link
Member

The fact still stays that the chrome extension doesn't need to use SwSpotify. I have no idea why was it connected to it in the first place. We can just scrape the current song data from the spotify tab, get lyrics and show them.

extension doesn't need SwSpotify but SwSpotify needs the chrome extension, it's meant to extend support for SwSpotify.

For example, suppose you create a python application that interacts with Spotify and you use SwSpotify, now how do you make it support the Spotify Web Player w/o the Chrome Extension?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants