Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spleeter for source separation #30

Open
shoegazerstella opened this issue Jan 8, 2020 · 6 comments
Open

Add Spleeter for source separation #30

shoegazerstella opened this issue Jan 8, 2020 · 6 comments

Comments

@shoegazerstella
Copy link

Hi,
I think it could be cool to add spleeter for performing the source separation.
If you are interested in accepting a pull request I've done it here.

@aadibajpai
Copy link
Member

Yes please! We have wanted to do that for quite some time but haven't really gotten around to it yet :(

@shoegazerstella
Copy link
Author

Made this branch https://github.com/shoegazerstella/autosynch/tree/spleeter-dl in which I added spleeter and also the possibility to download the audio using youtube-dl.

usage is below in the readme

python playback.py [artist] [song_title] -v spleeter

I also added a Dockerfile (but need to test properly), since I've got an error on macos when using open-unmix and wanted to test on ubuntu. That's the error:

RuntimeError: fft: ATen not compiled with MKL support

Made a lot of changes in the imports too, maybe I'll just create a pull request to add the new branch

@aadibajpai
Copy link
Member

Made this branch https://github.com/shoegazerstella/autosynch/tree/spleeter-dl in which I added spleeter and also the possibility to download the audio using youtube-dl.

usage is below in the readme

python playback.py [artist] [song_title] -v spleeter

I also added a Dockerfile (but need to test properly), since I've got an error on macos when using open-unmix and wanted to test on ubuntu. That's the error:

RuntimeError: fft: ATen not compiled with MKL support

Made a lot of changes in the imports too, maybe I'll just create a pull request to add the new branch

Yes a new branch would be great!

So I thought about integrating youtube-dl but then the issue was sometimes the music video has additional audio before or after the actual song like https://www.youtube.com/watch?v=DK_0jXPuIr0 that can throw off sync.

That said, it should work for most songs so that is very welcome too 😄

@chriswang030
Copy link
Collaborator

youtube-dl would be great but as Aadi mentioned the biggest trouble is finding a suitable video without too much wacky stuff going on. You'd be better off downloading the file yourself.

@aadibajpai
Copy link
Member

A metric I was thinking of was if the duration is the same on both Spotify and YouTube then the audio can be expected to be the same too. Yet to test it though, and it probably involves Spotify API usage

@DumbMachine
Copy link

image
Genius API, many times gives the time stamp where the music begins in a video. Though this may still have some errors as in many music videos there are segments without music in between.
A hacky way of using youtube-dl would be to search for music with tags lyrics, audio etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants