Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic issue in DocumentationProcessor #3040

Open
finestructure opened this issue May 5, 2024 · 1 comment
Open

Logic issue in DocumentationProcessor #3040

finestructure opened this issue May 5, 2024 · 1 comment
Assignees
@daveverwer

Comments

@finestructure
Copy link
Member

I noticed this issue while working on the DocRoute changes. We're assigning the canonical url parameter and then testing it against itself:

CleanShot 2024-05-05 at 11 45 17@2x

This is from commit f63d212 in PR #2360

I don't think this is working as intended, @daveverwer , is it?
@daveverwer daveverwer self-assigned this May 6, 2024
@daveverwer
Copy link
Member

What's wrong with an occasional if true?

I'll figure out what I meant here when I fix up the canonicals on top of the new documentation routing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daveverwer daveverwer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daveverwer @finestructure