Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ingredient existence check in that one model where I'm rescuing the exception #151

Open
johnhutch opened this issue Jan 8, 2018 · 0 comments

Comments

@johnhutch
Copy link
Collaborator

See comment here: olbrich/ruby-units#156 (comment)

@johnhutch I think you can use Unit.defined?("unitname") for this purpose.
Edit: Unit.defined? does not recognize prefixes so it won't work for those cases e.g. Unit.defined?('cm') is false but Unit.new('cm') will work.

Could this lead to cleaner, more efficient code than the exception rescue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant