From df31b672f8e172a186dc7b14fd5c3211fb446fed Mon Sep 17 00:00:00 2001 From: Tasko Olevski Date: Thu, 24 Oct 2024 01:22:46 +0200 Subject: [PATCH] squashme: minor fixes --- .../renku_data_services/notebooks/blueprints.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/components/renku_data_services/notebooks/blueprints.py b/components/renku_data_services/notebooks/blueprints.py index 9fe1a6bfb..28e8c66ec 100644 --- a/components/renku_data_services/notebooks/blueprints.py +++ b/components/renku_data_services/notebooks/blueprints.py @@ -317,11 +317,12 @@ async def _handler( ) if csr.target_path is not None and not PurePosixPath(csr.target_path).is_absolute(): csr.target_path = (work_dir / csr.target_path).as_posix() - if csr_id in dcs_secrets and csr.configuration is not None: - raise errors.ValidationError( - message=f"Overriding the storage configuration for storage with ID {csr_id} " - "is not allowed because the storage has an associated saved secret.", - ) + # TODO: The UI always does this check if it is acceptable/safe + # if csr_id in dcs_secrets and csr.configuration is not None: + # raise errors.ValidationError( + # message=f"Overriding the storage configuration for storage with ID {csr_id} " + # "is not allowed because the storage has an associated saved secret.", + # ) dcs[csr_id] = dcs[csr_id].with_override(csr) repositories = [Repository(url=i) for i in project.repositories] secrets_to_create: list[V1Secret] = []