-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContainerImage isn't validated in environments endpoints #551
Comments
Thanks @Panaetius, for the UI side, we could use trimming before sending. Is there a validation rule for container image references? |
https://docs.docker.com/reference/cli/docker/image/tag/ describes it a bit, which refers to this spec: https://github.com/opencontainers/distribution-spec/blob/main/spec.md#pulling-manifests which has I don't think there's a ready made rule available for this in pydantic or similar. |
OK, thanks! Not sure if this is usable at the moment since it does not seem to cover using a digest (which is valid). Example: |
We should validate that the image name for an environment is actually a valid image identifier. Currently it accepts any character, including spaces. This then causes session launch to fail because it can't find the image, but is very difficult to spot that this happened in the input field. (so
renku/myimage
doesn't work whererenku/myimage
works).ideally we'd also validate this in the UI.


For reference, one of these two won't launch(due to a space in the beginning):
The text was updated successfully, but these errors were encountered: