Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong attribute "invoice_number" is used #215

Open
dernst-art opened this issue Sep 28, 2021 · 0 comments
Open

Wrong attribute "invoice_number" is used #215

dernst-art opened this issue Sep 28, 2021 · 0 comments

Comments

@dernst-art
Copy link

dernst-art commented Sep 28, 2021 •
edited
Loading

Hi,

SyliusPayPalPlugin version affected: v1.3.0

Description
During creation and updates of PayPal orders and payments there is used the attribute "invoice_number", this attribute got ignored from PayPal.

Possible Solution
According to the PayPal API doc the attribute should be named "invoice_id"

This has to be changed in the following files:
@maikrosenthal maikrosenthal mentioned this issue Jun 11, 2024
Merged
GSadee added a commit that referenced this issue Jul 2, 2024
@GSadee
bug #296 Fix and enhance PayPalPurchaseUnit (maikrosenthal)
7c1b1fc 
This PR was merged into the 1.6 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.6 (bug fixes, improvements)
| Bug fix?        | yes
| New feature?    | no
| Related tickets | fixes #215

This will fix the wrong attribute "invoice_number" and add the "shipping_discount" to PayPalPurchaseUnit

Commits
-------

f4d63b2 Use constructor property promotion
a97fada Fixed wrong attribute invoice_number
b7ab860 Also transmit the shipping discount
1178884 Implemented suggested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dernst-art