Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create post-processing conversion for combinatorial derivations #4

Open
wdrav opened this issue Jun 16, 2023 · 0 comments
Open

Create post-processing conversion for combinatorial derivations #4

wdrav opened this issue Jun 16, 2023 · 0 comments
Assignees

Comments

@wdrav
Copy link
Collaborator

wdrav commented Jun 16, 2023

Is your feature request related to a problem? Please describe.
Currently, the post-processing tool (located in temp3.py) goes through each of the child objects for each combinatorial derivation, moving up the hierarchy of features, and decides whether or not to convert each object to a component based on whether or not they have a combinatorial derivation as a child, or a multi-object feature (Appears in the template as a list of features in a single part column). Currently, the tool is buggy, and picks up items that shouldn't be included in the conversion.

Describe the solution you'd like
The change would be to create a two pass system, where the first pass goes through each current combinatorial derivation to check if it has a multi-object feature, which if it does, is left alone. Following this first pass through, the combinatorial derivations that remain without the multi-object will have each of their parts checked to see if they're combinatorial derivations. If so, they would remain combinatorial derivations and otherwise will be converted into components.

Describe alternatives you've considered
Another way of solving this issue would be in rethinking the current graph navigation system, in making sure that the hierarchy is completely correct before determining what the object should be converted to, if anything. This would take more time, but could possibly be more comprehensive.

@cjmyers
@saisam17

@wdrav wdrav self-assigned this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant