forked from SynBioHub/Submit-Testing
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flapjack overwrite #2
Comments
@Gonza10V has confirmed that if confirm=False then objects are fully overwritten |
Yes, sorry for the late response I had a meeting with Tim and he confirmed that, he gave the approval for the refactor of the function according to your use case. I would add the argument overwrite=False or True to use in these cases. The argument confirm is for a more manual use case when you try to create an object to know that it exists and then make the choice of overwrite or get the existing object.
Would the overwrite argument be useful for you?
Gonzalo Vidal
…________________________________
From: JMante1 ***@***.***>
Sent: Tuesday, October 18, 2022 10:28 PM
To: SynBioDex/Xperimental-Data-Convertor-Server ***@***.***>
Cc: GONZALO ANDRÉS VIDAL PENA ***@***.***>; Mention ***@***.***>
Subject: Re: [SynBioDex/Xperimental-Data-Convertor-Server] Flapjack overwrite (Issue #2)
@Gonza10V<https://github.com/Gonza10V> has confirmed that if confirm=False then objects are fully overwritten
—
Reply to this email directly, view it on GitHub<#2 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIMFC73ZOEVFRRAJFNGLZI3WD4JADANCNFSM6AAAAAAQ73GLSE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Yes. It would be great to have a overwrite=False or True for the case that confirm=False. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment fj.create is called using confirm=False (it cannot ask for user input on each item if it is going to be used on the server interface). However, this may thus be overwriting all flapjack data. It should be updated so there is an option of overwrite or not as well as confirmation. Then an input for flapjack overwrite can be added to the form too.
The text was updated successfully, but these errors were encountered: