Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pySBOL remove() method causes Python to crash #171

Open
kirichoi opened this issue Aug 8, 2017 · 3 comments
Open

pySBOL remove() method causes Python to crash #171

kirichoi opened this issue Aug 8, 2017 · 3 comments
Labels

Comments

@kirichoi
Copy link

kirichoi commented Aug 8, 2017

It seems like remove() method is crashing Python. Python unittest tests remove functions by executing something like

doc.sequences.remove(0)

and assert an error to be raised when the object is assessed. Has there been any changes to the function making the above expression invalid?

@kirichoi kirichoi added the Bug label Aug 8, 2017
@bbartley
Copy link
Contributor

bbartley commented Aug 8, 2017

Yes, I introduced the bug. It's trying to delete a pointer twice. I'll look into it.

@bbartley
Copy link
Contributor

bbartley commented Aug 8, 2017

The error occurs only in Python, not libSBOL, and is introduced in libsbol.i line 174. This is one of those annoying SWIG memory management issues, and will take some time to sort out. For now I've commented the line out (see 4884ff5), and the test should pass. (It will result in a memory leak when calling the remove method, however.)

@bbartley
Copy link
Contributor

Related to #140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants