Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker doesn't have rsync #104

Closed
ashgillman opened this issue Jun 17, 2021 · 7 comments · Fixed by #107
Closed

Docker doesn't have rsync #104

ashgillman opened this issue Jun 17, 2021 · 7 comments · Fixed by #107
Milestone
v3.1

Comments

@ashgillman
Copy link
Member

When building Docker:

/devel/SIRF-Exercises/scripts/download_data.sh: line 195: rsync: command not found
@ashgillman
Copy link
Member Author

I used rsync for the -u and -a flags, but on closer inspection, good old cp supports these

@KrisThielemans
Copy link
Member

ok. what about checking if rsync is present, if so use it, otherwise use cp? More complicated, but rsync does feel nicer. It could prevent problems with files being open in one notebook, and people redownloading again by accident.

@KrisThielemans KrisThielemans added this to the v3.1 milestone Jun 17, 2021
@ashgillman
Copy link
Member Author

I think cp -ua X Y and rsync -ua X Y are almost functionally equivalent? Make a copy, but only if src is newer, and maintain all file metadata?

@KrisThielemans
Copy link
Member

alright! I didn't know that.

Please check if MacOS cp supports it...

@ashgillman
Copy link
Member Author

No, MacOS doesn't...
I'll make a function

@ashgillman
Copy link
Member Author

It was getting bigger than Ben Hur, I think just using cp is acceptable. These scripts I suppose would be re-written in Python for #83 ?

@ashgillman ashgillman mentioned this issue Jun 17, 2021
Merged
KrisThielemans pushed a commit that referenced this issue Jun 17, 2021
@ashgillman
Use more portable cp in lieu of rsync (#107)
59145c5 
Fixes #104
@KrisThielemans
Copy link
Member

agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1
Development

Successfully merging a pull request may close this issue.

Use more portable cp in lieu of rsync ashgillman/SIRF-Exercises
2 participants
@ashgillman @KrisThielemans