Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add option to turn off possibility of archiving for project members #393

Closed
danymat opened this issue Jan 22, 2025 · 3 comments

Comments

@danymat
Copy link

danymat commented Jan 22, 2025

Hello,

Right now, we see that all person as project members in a project can archive it.
However, we think it can be a process issue as it means that everyone on the pentest can archive the project and we want to restrict archiving and unarchiving only to global archivers.

Would it be possible to consider an option to let only global archivers to archive/unarchive like:

PROJECT_MEMBER_CAN_ARCHIVE_PROJECTS=false

This could do one of those:

  1. Do not let Project Members be used as archive/unarchive person
  2. Let them be used as archive/unarchive person but they can't trigger the archiving by themselves.

What is your point of view regarding this option ?

@aronmolnar
Copy link
Contributor

We can implement this and we suggest the following implementation details:

If this option is set, only archiving users are allowed to archive projects and restore projects. This means that encryption happens with fewer encryption keys and it will be more difficult to keep up the quorum for restoring projects (this could lead to availability problems).

If a user is project member and at the same time an archiving user, the user will still have the permission to archive and restore projects.

This cannot be applied to already archived projects. If this system is necessary to be applied to already-archived projects, they must be restored and rearchived after the option was set.

@MWedl
Copy link
Contributor

MWedl commented Jan 27, 2025

Implemented setting PROJECT_MEMBERS_CAN_ARCHIVE_PROJECTS (enabled by default) in https://github.com/Syslifters/sysreptor/releases/tag/2025.12

@MWedl MWedl closed this as completed Jan 27, 2025
@danymat
Copy link
Author

danymat commented Jan 27, 2025

Thanks, will try it out !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants