Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java might be redundant for Jupyter support #92

Open
NCGThompson opened this issue Jun 17, 2024 · 1 comment
Open

Java might be redundant for Jupyter support #92

NCGThompson opened this issue Jun 17, 2024 · 1 comment

Comments

@NCGThompson
Copy link

The installation instructions for the Jupyter Kernel say to install OpenJDK before installing Conda. However, running conda install jupyter-sysml-kernel will install the Conda package openjdk which seems to have the effect of reinstalling OpenJDK but only for that specific Conda environment.

Activating the Conda environment sets the JAVA_HOME environment variable to its own Java installation. If I understand Jupyter correctly, the kernel will always run in the environment it was installed with, so the manually installed OpenJDK won't ever be ran in Jupyter. If what I said is correct in all cases, the Java should be removed from the installation instructions.

@mike-mbse-dev
Copy link

mike-mbse-dev commented Jul 26, 2024

I do agree on the fact that it is unnecessary to have an installation of java.

I tried to follow instructions with a Windows environment with miniconda and not setting any java env variable. First jupyter was not loading the kernel due to not finding the kernel file. At the end I had to change the kernel.json associatted to the jupyter-sysml-kernel to point to the path where there was the installed miniconda openjdk installation (if the env is activated I guess, as @NCGThompson points, the java openjdk should be directly recognized without having to change this line) and review that the -jar argument was pointing to the right path where the jupyter-sysml-kernel was actually installed (in my case by default it was pointing to a non existing pseudo linux distro dirpath)

It seems to load the kernel fine now, but the install.bat should be reviewed to automate the configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants