Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] #35

Open
mvargassv opened this issue Sep 20, 2024 · 7 comments
Open

[BUG] #35

mvargassv opened this issue Sep 20, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@mvargassv
Copy link

Describe the bug
The software can't copy files at PC on Windows 11

Unhandled exception log

To Reproduce
Steps to reproduce the behavior:

  1. Open any folder from mobile device
  2. Select file to copy
  3. Click right arrow in center screen to copy at PC
  4. nothing is copied

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS: [e.g. iOS] Windows 11 Pro

Additional context
I use version without .NET runtime, I install it separately

@mvargassv mvargassv added the bug Something isn't working label Sep 20, 2024
@T0biasCZe
Copy link
Owner

Do you have English windows or some other localization? I have noticed there is a bug when copying to the "Pictures" library in non english.

Eg in czech windows, the pictures library is called "Obrázky", but the ADB doesnt copy it to the obrázky folder, but it creates new folder
Something similar might be happening to you

@lordrak007
Copy link

Ahoj,
ten program by s tím mohl počítat y vyrobit složku bez mezer, diakritiky atd, na FS mít příznak skrytá a po zkopírování obsah "přesunout" tam, kam to uživatel chtěl. Většinou to budou maximálně stovky souborů, tzn. přesun bude rychlý. Nebo to hlídat per soubor a po každém jenom zkopírování udělat na pozadí přesun, aby se to postupně pěkně objevovalo. Není to dokonalé řešení, ale lepší, aby to fungovalo alespoň nějak?

@T0biasCZe
Copy link
Owner

To není mezerama/diakritikou. Ono prostě ta složka se na disku jmenuje "Pictures" anglicky, ikdyž ma človek česky windows. Jako "obrázky" se to ukazuje jen naoko, a windows s tím umí pracovat, on si to umí přeložit na Pictures automaticky na pozadí když načítáš soubory atd.
Akorát adb to neumí, takže se to rozbije když nema človek windows v angličtině, a vytvoří to actual složku s tím lokalizovaným jménem...
Tudíž jako fix by mělo stačit vzít ten lokalizovaný path, a přeložit ho zpátky do te anglické formy předtím než se provede ta ADB operace

@lordrak007
Copy link

Aha, už chápu. A proč se používá překlad, když to možná není třeba? Je to pravděpodobně jen mojí neznalostí použití Shell objektu, ale nestačí změnit v metodě "private void android2pc_Click(object sender, EventArgs e)"
string destinationFolder = ShellObject.FromParsingName(explorerBrowser1.NavigationLog.CurrentLocation.ParsingName).Properties.System.ItemPathDisplay.Value;
na
string destinationFolder = explorerBrowser1.NavigationLog.CurrentLocation.ParsingName;
?

@T0biasCZe T0biasCZe reopened this Sep 29, 2024
@T0biasCZe
Copy link
Owner

T0biasCZe commented Sep 29, 2024

Spaghetti code moment
mělo by to byt opravene teď...

it should be fixed now for all languages

@T0biasCZe
Copy link
Owner

https://github.com/T0biasCZe/AdbFileManager/releases/tag/v1.9.1

@bjspi
Copy link

bjspi commented Oct 12, 2024

Thanks, seems to be fixed. Just had the same problem when clicking on the "Desktop" icon (in a german Windows version) on the right panel as target folder.
The folder was set to "C:\Benutzer\XXXXX\Desktop" - which is how Windows displays the folder also in Explorer (using the german word "Benutzer") - but internally on the filesystem the folder is supposd to be "C:\Users\XXXXX\Desktop".

I was really wondering where my pictuers are :D And under C:, I than had two folders named "Benutzer", which was really weird. But yeah, I get it, one is "really" named Benutzer, the other one was named "Users".

However - now it seems fixed.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants