Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Evaluate and Potentially Re-Implement RobustCloudCommand Module #199

Open
jonnybottles opened this issue Dec 13, 2024 · 0 comments
Assignees
Labels
status/backlog In backlog / validated type/feature New feature or request

Comments

@jonnybottles
Copy link
Collaborator

What problem would this feature solve?

The current Get-HawkTenantInboxRules function references a module called RobustCloudCommand, which is no longer available in the PowerShell Gallery. While a two-year-old GitHub repository exists for this module, its availability and relevance need to be evaluated. Without this module, the functionality of Get-HawkTenantInboxRules is limited.

  • The unavailability of the RobustCloudCommand module may lead to errors or incomplete data retrieval in Hawk's tenant-wide operations.
  • The project lacks clarity on whether the module is still needed and, if so, how it can be incorporated into the Hawk codebase.

Proposed Solution

Research the current functionality of RobustCloudCommand to determine its necessity. If required, implement the module locally by pulling down its code from GitHub and integrating it as an internal Hawk function. This ensures continued functionality without external dependencies.

Technical Requirements

  • Research Task:
    1. Verify whether RobustCloudCommand is still relevant for tenant-wide user inbox rule collection.
    2. Identify specific operations in Get-HawkTenantInboxRules that depend on RobustCloudCommand.
  • Implementation Task:
    1. If necessary, pull down the RobustCloudCommand module from GitHub.
    2. Refactor its code into an internal Hawk function.
    3. Remove external dependency on the module to avoid breaking changes in the future.

Implementation Approach

  1. Clone the RobustCloudCommand GitHub repository.
  2. Review its implementation to identify which parts are relevant to the Hawk project.
  3. Create an equivalent internal function within Hawk that replicates the required functionality.
  4. Update Get-HawkTenantInboxRules to use the internal implementation of RobustCloudCommand.
  5. Perform unit tests to ensure compatibility and stability of the refactored function.

Acceptance Criteria

  • Determine whether the RobustCloudCommand module is essential for Hawk's current and future needs.
  • If re-implementation is necessary:
    • Create an internal function replicating the required functionality.
    • Successfully execute Get-HawkTenantInboxRules using the refactored function without errors.
    • Eliminate dependency on external modules while maintaining the same level of functionality.
  • Document all changes and update user documentation to reflect the updated implementation.
@jonnybottles jonnybottles added type/feature New feature or request status/backlog In backlog / validated labels Dec 13, 2024
@jonnybottles jonnybottles self-assigned this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/backlog In backlog / validated type/feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant