Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rejection bug #15

Open
T1mmos opened this issue May 23, 2020 · 1 comment
Open

Rejection bug #15

T1mmos opened this issue May 23, 2020 · 1 comment
Assignees
@T1mmos
Labels
bug Something isn't working invalid This doesn't seem right wontfix This will not be worked on

Comments

@T1mmos
Copy link
Owner

T1mmos commented May 23, 2020 •
edited
Loading

Client log:

TRACE AWT-EventQueue-0 :: Cannot execute command C_SolShowPull (mousePressed/card) because: Cannot move from DEPOT to LAYDOWN
INFO AWT-EventQueue-0 :: Executing 'C_SolShowUse', id=d68df3e9-05dd-40d7-be26-91c95aca05bb...
INFO AWT-EventQueue-0 :: Executing 'C_SolShowMove', id=97ea972e-f9e7-42f0-a43a-dfee5329f25f...
TRACE AWT-EventQueue-0 :: CommandHistory::addAwaiting 'C_SolShowMove', id=97ea972e-f9e7-42f0-a43a-dfee5329f25f
TRACE AWT-EventQueue-0 :: Cannot execute command C_Undo (ActionService) because: CommandHistory cannot undo
TRACE AWT-EventQueue-0 :: Cannot execute command C_Redo (ActionService) because: CommandHistory cannot redo
INFO UI :: TCP read (192.168.0.165:9010) :: Received command 'C_Reject' from '192.168.0.165:9010'
INFO AWT-EventQueue-0 :: Executing 'C_Reject', id=cc4c8364-e3e4-4131-9b57-242ed33640d2...
TRACE AWT-EventQueue-0 :: CommandHistory::reject id=97ea972e-f9e7-42f0-a43a-dfee5329f25f
TRACE AWT-EventQueue-0 :: Cannot execute command C_Undo (ActionService) because: CommandHistory cannot undo
TRACE AWT-EventQueue-0 :: Cannot execute command C_Redo (ActionService) because: CommandHistory cannot redo

Server log:

INFO    Server :: TCP read (192.168.0.151:49910) :: Received command 'C_SolShowMove' from '192.168.0.151:49910'
INFO    Server :: CommandExecution               :: Processing command 'C_SolShowMove', id=ab9221ff-692a-4b5f-8bd1-bff9a1a2b1c5
INFO    Server :: CommandExecution               :: Can't execute syncable command: 'C_SolShowMove'. Responding with a C_Reject. Reason: Source stack doesn't contain the card with id f7002ef4-41ea-4902-999d-53d12b7be0f7

Ironically, the client was finally able to make his move when the server closed down! This is explained by the server no longer sending C_Reject messages, so the client can do what he wants. However, the client should have detected that the connection to the server was lost?
@T1mmos T1mmos self-assigned this May 23, 2020
T1mmos added a commit that referenced this issue Jul 8, 2020
@T1mmos
fixed unit tests and fixed a bug in rejection of quarantined commands…
b7e17f1 
…, hopefully fixes #14 and/or #15
@T1mmos
Copy link
Owner Author

T1mmos commented Jul 8, 2020

b7e17f1 might solve this but this is not yet confirmed.

@T1mmos T1mmos added bug Something isn't working invalid This doesn't seem right wontfix This will not be worked on labels Jul 8, 2020
T1mmos pushed a commit that referenced this issue Dec 30, 2020
Dialog refactoring #15
fcd7ffb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@T1mmos T1mmos

Labels
bug Something isn't working invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@T1mmos