Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be consistent with item names #2

Open
doy opened this issue Jul 6, 2013 · 0 comments
Open

be consistent with item names #2

doy opened this issue Jul 6, 2013 · 0 comments

Comments

@doy
Copy link
Member

doy commented Jul 6, 2013

Some items are the full identity, others need $type of $item, others aren't items at all ((un)holy water, uncharged). These should all be actual item identities, and things that aren't identities should be returned some other way.

Maybe this should actually just return NetHack::Item instances directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant