Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor how configuration options are loaded #102

Closed
Derpius opened this issue Jul 16, 2023 · 1 comment · Fixed by #110
Closed

Refactor how configuration options are loaded #102

Derpius opened this issue Jul 16, 2023 · 1 comment · Fixed by #110
Assignees
@Derpius
Labels
jira ticket This issue was created from a Jira ticket during the migration to GitHub issues scope - cli Command line experience

Comments

@Derpius
Copy link
Member

Derpius commented Jul 16, 2023

Context

Currently, we have completely separate command line options and config options, which we then manually merge together in the top level lest.lua file.

We should have a central service that handles loading and merging config options, which we can then simply register a new option with.

Scope

todo

Acceptance criteria

todo
@Derpius Derpius added enhancement jira ticket This issue was created from a Jira ticket during the migration to GitHub issues scope - cli Command line experience labels Jul 16, 2023
@Derpius Derpius mentioned this issue Jul 16, 2023
Closed
@Derpius Derpius self-assigned this Dec 3, 2023
@Derpius
Copy link
Member Author

Derpius commented Dec 3, 2023

Will fix #97 and #104

@Derpius Derpius linked a pull request Dec 3, 2023 that will close this issue
102 - Rewrite configuration handling #110
Merged
@Derpius Derpius mentioned this issue Dec 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Derpius Derpius

Labels
jira ticket This issue was created from a Jira ticket during the migration to GitHub issues scope - cli Command line experience
Projects
Lest
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

102 - Rewrite configuration handling TAServers/lest
1 participant
@Derpius