errs

impl/pkg/server/pkarr.go

@@ -3,8 +3,10 @@ package server
 import (
 	"crypto/ed25519"
 	"encoding/binary"
+	"fmt"
 	"io"
 	"net/http"
+	"strings"
 
 	"github.com/gin-gonic/gin"
 
@@ -56,6 +58,11 @@ func (r *PkarrRouter) GetRecord(c *gin.Context) {
 
 	resp, err := r.service.GetPkarr(c, *id)
 	if err != nil {
+		// TODO(gabe): provide a more maintainable way to handle custom errors
+		if strings.Contains("spam", err.Error()) {
+			LoggingRespondErrMsg(c, fmt.Sprintf("too many requests for bad key %s", *id), http.StatusTooManyRequests)
+			return
+		}
 		LoggingRespondErrWithMsg(c, err, "failed to get pkarr record", http.StatusInternalServerError)
 		return
 	}

impl/pkg/service/pkarr.go

@@ -6,13 +6,12 @@ import (
 	"sync/atomic"
 	"time"
 
-	"github.com/goccy/go-json"
-	"github.com/tv42/zbase32"
-
 	ssiutil "github.com/TBD54566975/ssi-sdk/util"
 	"github.com/allegro/bigcache/v3"
 	"github.com/anacrolix/torrent/bencode"
+	"github.com/goccy/go-json"
 	"github.com/sirupsen/logrus"
+	"github.com/tv42/zbase32"
 
 	"github.com/TBD54566975/did-dht-method/internal/util"
 
@@ -139,7 +138,7 @@ func (s *PkarrService) GetPkarr(ctx context.Context, id string) (*pkarr.Response
 
 	// if the key is in the badGetCache, return an error
 	if _, err := s.badGetCache.Get(id); err == nil {
-		return nil, ssiutil.LoggingCtxErrorMsgf(ctx, err, "key [%s] looked up too frequently, please wait a bit before trying again", id)
+		return nil, ssiutil.LoggingCtxErrorMsgf(ctx, err, "bad key [%s] rate limited to prevent spam", id)
 	}
 
 	// first do a cache lookup

impl/pkg/service/pkarr_test.go

@@ -132,7 +132,7 @@ func TestPkarrService(t *testing.T) {
 
 		// try it again to make sure the cache is working
 		got, err = svc.GetPkarr(context.Background(), "uqaj3fcr9db6jg6o9pjs53iuftyj45r46aubogfaceqjbo6pp9sy")
-		assert.ErrorContains(t, err, "looked up too frequently, please wait a bit before trying again")
+		assert.ErrorContains(t, err, "rate limited to prevent spam")
 		assert.Empty(t, got)
 	})