Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Update SendPage to remove "Verifying DAP..." loading message #285

Closed
Tracked by #298
ethanwlee opened this issue Sep 5, 2024 · 3 comments · Fixed by #305
Closed
Tracked by #298

Update SendPage to remove "Verifying DAP..." loading message #285

ethanwlee opened this issue Sep 5, 2024 · 3 comments · Fixed by #305

Comments

@ethanwlee
Copy link
Contributor

  • similar to what was achieved in chore: remove polling widgets #281, we want to consolidate any consecutive loading spinners into one loading page
  • currently, you can go to SendPage via the send tab in the bottom navigation bar. from here, typing in a dap (e.g. @moegrammer/didpay.me) and hitting the next button triggers a "Verifying DAP..." loading message followed by a "Fetching offerings..." loading message which means you have entered the payment flow starting at PaymentAmountPage
  • the goal of this issue is to remove the "Verifying DAP..." loading message in SendPage and instead put a small loading spinner to the right of the DAP input form when resolving the DAP
    • old flow: input DAP -> hit next -> see "Verifying DAP..." -> see "Fetching offerings..." -> enter PaymentAmountPage
    • new flow: input DAP -> hit next -> see small loading spinner next to DAP input form -> see "Fetching offerings..." -> enter PaymentAmountPage
@victoreronmosele
Copy link
Contributor

.take

Copy link

github-actions bot commented Oct 3, 2024

Thanks for taking this issue! Let us know if you have any questions!

@victoreronmosele
Copy link
Contributor

Hi @ethan-tbd, I made a PR implementing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants