Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eradicate type-specific "Ref" variants in schema #1063

Closed
alecthomas opened this issue Mar 12, 2024 · 1 comment · Fixed by #1074
Closed

Eradicate type-specific "Ref" variants in schema #1063

alecthomas opened this issue Mar 12, 2024 · 1 comment · Fixed by #1074

Comments

@alecthomas
Copy link
Collaborator

They're proliferating at a rate of knots and are increasing the noise and complexity of the schema. Instead, switch to using the single untyped Ref, and a single resolver function that returns different types.
@alecthomas alecthomas added the good first issue Good for newcomers label Mar 12, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Mar 12, 2024
@alecthomas alecthomas mentioned this issue Mar 12, 2024
Open
@alecthomas
Copy link
Collaborator Author

Duplicate of #1043

@alecthomas alecthomas marked this as a duplicate of #1043 Mar 12, 2024
@alecthomas alecthomas removed good first issue Good for newcomers triage Issue needs triaging labels Mar 12, 2024
worstell added a commit that referenced this issue Mar 13, 2024
@worstell
chore: remove type-specific Ref variants from schema
30d5fdc 
fixes #1043
fixes #1063
@worstell worstell mentioned this issue Mar 13, 2024
Merged
worstell added a commit that referenced this issue Mar 13, 2024
@worstell
chore: remove type-specific Ref variants from schema
5ed8bca 
fixes #1043
fixes #1063
worstell added a commit that referenced this issue Mar 13, 2024
@worstell
chore: remove type-specific Ref variants from schema
96540ab 
fixes #1043
fixes #1063
worstell added a commit that referenced this issue Mar 13, 2024
@worstell
chore: remove type-specific Ref variants from schema (#1074)
97f1b89 
fixes #1043
fixes #1063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove type-specific Ref variants from schema TBD54566975/ftl
1 participant
@alecthomas