Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redeploying message should be cleaned up #1077

Closed
alecthomas opened this issue Mar 13, 2024 · 0 comments · Fixed by #1091
Closed

Redeploying message should be cleaned up #1077

alecthomas opened this issue Mar 13, 2024 · 0 comments · Fixed by #1091
Assignees
@wesbillman

Comments

@alecthomas
Copy link
Collaborator 

backend | info: idv's schema changed; redeploying: []
  1. It shouldn't be printing a raw slice directly, it should do strings.Join(modules, ", ") or similar
  2. If there are no modules to redeploy, it shouldn't print.
@alecthomas alecthomas added the good first issue Good for newcomers label Mar 13, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Mar 13, 2024
@alecthomas alecthomas mentioned this issue Mar 13, 2024
Open
@wesbillman wesbillman self-assigned this Mar 14, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Mar 14, 2024
@wesbillman wesbillman removed the good first issue Good for newcomers label Mar 14, 2024
@wesbillman wesbillman mentioned this issue Mar 14, 2024
Merged
wesbillman added a commit that referenced this issue Mar 14, 2024
@wesbillman
chore: improve dev deployment messaging (#1091)
34b5a3f 
Fixes #1077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesbillman wesbillman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: improve dev deployment messaging TBD54566975/ftl
2 participants
@alecthomas @wesbillman