Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about whether events table serves the role of audit logs #1236

Open
matt2e opened this issue Apr 11, 2024 · 1 comment
Open

Think about whether events table serves the role of audit logs #1236

matt2e opened this issue Apr 11, 2024 · 1 comment
Labels
good first issue Good for newcomers techdebt Issue is technical debt

Comments

@matt2e
Copy link
Collaborator

matt2e commented Apr 11, 2024

Do we want individual tables for different kinds of audit logs (eg cronjob executions)? Or is the combined events table good for this purpose?
What is missing from the events/requests table at the moment? Possibly deployment key rather than just module name.

@github-actions github-actions bot added the triage Issue needs triaging label Apr 11, 2024
@alecthomas
Copy link
Collaborator

I was thinking about this a bit more, and I believe we should get rid of the requests table. The events table is used for the user-experience aspect of FTL, so that should stay, but it is not an audit log.

When we do end up needing audit logs, we should just dump data into some external system like Kafka.

@alecthomas alecthomas added techdebt Issue is technical debt good first issue Good for newcomers and removed triage Issue needs triaging labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers techdebt Issue is technical debt
Projects
None yet
Development

No branches or pull requests

2 participants