Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three bugs that I don't know how to reproduce or fix #1298

Closed
alecthomas opened this issue Apr 18, 2024 · 0 comments · Fixed by #1304
Closed

Three bugs that I don't know how to reproduce or fix #1298

alecthomas opened this issue Apr 18, 2024 · 0 comments · Fixed by #1304
Assignees
Labels
bug Something isn't working

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented Apr 18, 2024

@michaelneale cloned down the ftl-examples and was unable to build the online-boutique for reasons that are not clear. I fixed a bunch of issues, but hit two weird bugs that are reproducible in this branch.

Bugs are:

  1. We get the message warn: "checkout" build skipped because its dependency "shipping" failed to build even though shipping hasn't failed in any visible way.
  2. We get error: initial deploy failed: 14:3-3: ingress verb getQuote: couldn't resolve response body type currency.Money
  3. There's also a meta bug in that "initial deploy failed" doesn't tell me which file the failure is occurring in.
🐚 ~/dev/ftl-examples $ ftl dev online-boutique/backend --recreate
info: Starting FTL with 1 controller(s)
info:currency: Building module
info:cart: Building module
info:ad: Building module
info:ad: Deploying module
info:currency: Deploying module
info:cart: Deploying module
info:payment: Building module
info:shipping: Building module
info:productcatalog: Building module
info:payment: Deploying module
warn: "checkout" build skipped because its dependency "shipping" failed to build
info:recommendation: Building module
info:productcatalog: Deploying module
info:recommendation: Deploying module
info:controller0: Deployed dpl-ad-1m5ckbhogm6feil5
info:controller0: Deployed dpl-currency-1flmrlirote5ta9r
info:controller0: Deployed dpl-recommendation-58ikzredh79ww5d6
info:controller0: Deployed dpl-payment-9n2robh5f3vfo4w
info:controller0: Deployed dpl-productcatalog-099pwzdrb9zvpkq
info:controller0: Deployed dpl-cart-23tfpvcga9c6l85r
info: Modules waiting to build: shipping, checkout
error: initial deploy failed: 14:3-3: ingress verb getQuote: couldn't resolve response body type currency.Money
@github-actions github-actions bot added the triage Issue needs triaging label Apr 18, 2024
@alecthomas alecthomas changed the title Two bugs that I don't know how to reproduce or fix Three bugs that I don't know how to reproduce or fix Apr 18, 2024
@alecthomas alecthomas added the bug Something isn't working label Apr 18, 2024
@wesbillman wesbillman self-assigned this Apr 18, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Apr 18, 2024
wesbillman added a commit that referenced this issue Apr 18, 2024
We don't have access to the full schema at this point, so we can't
validate that external types exist

Fixes #1298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants