unclear what --json does when running ftl config set

[mistermoe]

Repro

❯ ftl config set --json echo.default '{ "name": "beepboop"  }'
ftl: error: unknown: JSON validation failed: default has wrong type, expected String found map[string]interface {}

❯ ftl config set --json echo.default "{\"name\": \"beepboop\"}"
ftl: error: unknown: JSON validation failed: default has wrong type, expected String found map[string]interface {}

❯ ftl config set --db --json echo.default '"{\"name\": \"beepboop\"}"'

Note

Finally! But yuck

❯ ftl config get echo.default
"{\"name\": \"beepboop\"}"

❯ ftl config set --db echo.default '{"name": 3}'

❯ ftl config get echo.default
"{\"name\": 3}"

[alecthomas]

The error is correct, but could perhaps be clearer... --json is for specifying strongly typed values, the FTL type is String and you're trying to put a map into it.

[matt2e]

--json has tripped a number of people up I think at this point. I wonder if we assume the input is a json string, and then have a fallback of if the expected type is string and it could not be parsed by json then we just use the input string as is...