Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About versions modules #57

Open
hsineternity opened this issue Oct 19, 2023 · 2 comments
Open

About versions modules #57

hsineternity opened this issue Oct 19, 2023 · 2 comments

Comments

@hsineternity
Copy link

hsineternity commented Oct 19, 2023

Why is there no Version included in the Module ID? In the /details API, the ModuleID is set to 'credentials.' Does this indicate that the Version module may not be required or has not been implemented?

Regarding the Version module, I have the following questions:

  1. Within the version API, it seems that the content for /versions and /details is hardcoded in the project. Is there a way to make this content more flexible or customizable?

  2. In /ocpi/versions, it appears that it doesn't enter the Crud class. How can we verify the correctness of the Authorization Token in this case? According to OCPI spec 2.2.1, specifically in the seventh chapter (Figure 22 - "The OCPI registration process"), /ocpi/versions should carry the token within the header.

@VictorTechs
Copy link
Collaborator

Hi @hsineternity, sorry for the very long response, if you are able to create a fix, we will review it and merge it.

@IOR88
Copy link
Contributor

IOR88 commented Sep 22, 2024

Hi @hsineternity we are now getting back to ocpi library maintenance, we will soon take care of the request you created, have you successfully integrated ocpi lib with your project ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants